Make all mapped database types case insensitive #6321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, a custom mapping type has to return an array of lowercase strings in
getMappedDatabaseTypes
or else Doctrine fails to retrieve the added type as bothAbstractPlatform::getDoctrineTypeMapping
andAbstractPlatform::hasDoctrineTypeMappingFor
do a lowercase conversion before the look-up. A devolper should not depend on internal representation.This PR addresses this by storing the mapped type in lowercase to
AbstractPlatform#doctrineTypeMapping
. This is in line withAbstractPlatform::registerDoctrineTypeMapping
, which does a lowercase conversion as well.